Potions in new format not working in 1.21.4 and potions in old format being 1 level too high
Summary
In recent builds (5.8.0 (release), 5.8.1 build 5345, and 5.8.0 build 5318) and in 1.21.4 (paper 113 and 164), mythic mobs potions are dropping as stone with extra component data when configured using the new format that I had to switch to a few versions before to get them to work.
If I go back to the old format, they DO work as potions, but are one level higher than they should be. (ie, a potion configured to be level 2 drops as a level 3 potion)
Steps to reproduce
Configure items as either of the below. Errors explained. (this happens with speed potions as well)
Examples:
If I have my potion configured like this:
HastePotion: Potion: Color: '#FF9999' Effects: - fast_digging{duration=2400;level=2;ambient=true;icon=true;particles=true}
then the potion drops as stone, with nbt about the potion in it...
If I have my potion configured like this: `HastePotion: Id: potion Display: 'Haste Potion' Options: Color: 255,153,153 PotionEffects:
- FAST_DIGGING 2400 1`
Then it works, but drops a level 2 haste potion.
Current behavior
See steps to reproduce section. Potions in the new format drop as stone. Potions in the old format work but are a level higher than they should be. (I've solved this for myself by using the old format and configuring potions a level lower than I want them, but it seems like something that should have a better fix.)
Intended correct behavior
Potions in both formats should work and should produce potions at the level configured.
Server log file
NOTE: this log shows a ton of mythic mobs errors that are reported separately, that are a result of my updating from 5.8.0 snapshot build 5318 to 5.8.0 release and 5.8.1 snapshot build 5345. Those errors did NOT occur in build 5318. I did the updates trying to fix this error... it didn't. (This Pastebin is booting with the old format potion configs if it matters.)
Debug log snippet
Provide a link to a Pastebin paste with an excerpt of your latest.log file that includes debug output where you trigger the bugged behavior.
No errors and nothing shown in debug mode with old format for potions:
[19:49:48 INFO]: [MythicMobs] Debug level has been set to 4 [19:50:00 INFO]: [BuycraftX] Fetching all due players... [19:50:01 INFO]: [BuycraftX] Fetched due players (0 found). [19:50:05 INFO]: Momshroom issued server command: /mm i get HastePotion
With new format potion (that gives a stone) ALSO has no errors and nothing shown in debug mode. It looks identical to the above.
Here is what the nbt on the stone looks like: https://prnt.sc/AEdzoovn3G6W
Proposed fixes
Make the new potion format give potions and/or have the old format give them at the correct level.