GitLab

Summary

I use timers and conditional skills to have my custom mobs equip different custom models for animations (Walking, Attacking, ETC.). For Example, I'd have two skills running with identical timers one that checks if the mob is moving and equips a walking animation and one that checks if it's not at the same time to equip an idle animation immediately once it stops moving. This worked fine prior to the 1.16.3 Dev Versions, now it seems that even if the mob is moving it can get past the "Moving False" condition and trigger the skills when it isn't supposed to. I didn't think there were any errors when I enabled debugging and tried replicating the issue.

Steps to reproduce

Here's the mob file: https://hastebin.com/ihuzenobeb.yaml

Here's the skills file: https://hastebin.com/tequgocuda.yaml

Current behavior

Equipment doesn't change as intended, in the case of the test mob above the iron helmet (moving equipment) flickers in and out when the mob is moving

Intended correct behavior

The mob should be wearing a diamond helmet when it is standing still, and when it's moving the skills should trigger the zombie to switch to the iron helmet until he stops again.

(This is a mob I setup specifically to replicate the bug, the actual use of this system is much more practical I promise)

Server log file

https://hastebin.com/qunexevolo.yaml

Debug log snippet

(The log file above is very short, there's no obvious error, just shows that the trigger doesn't go off when it should, in the test I simply spawned the mob in and switched to GM 0 to make him target and walk after me to try to trigger the skills)

Proposed fixes

From my testing the issue seems to be with the Moving condition not being able to correctly tell if the mob is moving or not, the Helmet that the mob is supposed to equip when it's standing still seems to be the one taking priority. So if I had to guess it's specifically an issue with the condition thinking the mob isn't moving when it in fact is. I'm no java developer so I don't know what the fix would be.

My own personal summary

I wanna wrap this up by just saying I'm very appreciative of the devs of this plugin, I hope this issue gets fixed soon because it's allowed me to do some crazy things with custom mobs in new versions. Sadly I cannot even begin to plan opening my server as long as this condition isn't working. If you guys have another alternative to achieve what I'm doing with the moving mechanic I'd love to know it. I'll attach an example of what I've been able to do with custom model data items as equipment that change with the moving mechanic. I've set this up with probably a dozen custom mod quality mobs in vanilla mc, I'll attach an example of what the combination of the equip skill and moving condition checks has allowed me to do.

mmfrogtest