Pvp bug with skills
Summary
In the newer versions/snapshots of mythicmobs, there's a bug where even when you have pvp off, wether it's with world manager, worldguard or other external plugins like mythicdungeons. Skills used to respect those pvp flags on disabled and custom skills wouldn't hurt other players. Now when using skills on the newer releases, you can just kill players in protected regions which was not the case ever since the release after Build 440
.
This causes major issues in protected areas where server owners want pvp disabled. I know there are worldguard flags that prevent using skills but in my case, I have an arena for bossfight in spawn, pvp arena's and it's just nice to use skills without restriction while the pvp flag is respected and dungeons where friendlyfire should be off.
Steps to reproduce
Have latest version 5.2.5/5.2.6 on your server 1.19.4
Current behavior
Skills hurt other players when using mmocore/mmoitems (used to be not the case)
Intended correct behavior
Protected areas from pvp shouldn't hurt players when using skills on eachother
Server log file
Proposed fixes
Revert back to pvp changes with Build 4403
where things worked with pvp protected areas.