Skip to content

GitLab

Closed
Created by evilsaloon@evilsaloon

Incorrect food consumption when interacting with disguised villager

Summary

Food is consumed in the background without the player's input when you hold right click with a non-full hunger bar while looking at a disguised villager.

Steps to reproduce

  1. Add the following mob via MythicMobs:
TestVillager:
  Type: VILLAGER
  Disguise: libraryaddict
  Options:
    Silent: true
    Profession: TOOLSMITH
    Type: DESERT
    Level: 5
  Trades:
    1:
      Item1: 3 WHITE_WOOL
      Result: 1 BLACK_WOOL
      MaxUses: 999999

And the following disguise via LibsDisguises:

libraryaddict: player libraryaddict setArmor GOLDEN_BOOTS,GOLDEN_LEGGINGS,GOLDEN_CHESTPLATE,GOLDEN_HELMET
    setItemInMainHand WRITTEN_BOOK setGlowing setSkin {"id":"a149f81bf7844f8987c554afdd4db533","name":"libraryaddict","properties":[{"signature":"afoGOO45t3iGvTyQ732AlugPOvj13/RNjM0/utYlD4PZ4ab4Jopbzr8Px75+ALdkyegoKNcfaH4aXzylMvL6mIwaRdL0af7pfGibMMCMJ8F1RAMl2WqRslKBKXHGS1OXxMweoXW+RRatGgZsUC1BjxHMwd4RuXxrV9ZZ7x1r4xouUXmMzn19wqNO9EeG2q8AgF/hZdrnJPdTTrqJs04r4vCQiFiQsTWiY/B5CBOTh6fw4NpOHeeiJwHOLvN+6xKnAm77nKawaKCSciDwt54EeZoE/Q5ReQUEFgj++jdyHb5PJbhGytr//mazpTVzvlDnO06CZqigbiueV2/ush2gKSXQeimCXeNZzcj/CFgqAmMSEZQW3qHp+DgoqqtBNabJa0FBzpbQQ/jQWzoHfmUC/hTf0A0+hgOe4NqDc+xXYf4A9M/6/0JHz0voWhQJi8QriM699DeeUa31bVdTdKjcyK6Zw6/HIOJt++eFnkf++/zKt0fMiqfdRamSqR/K3w+Kk7cs2D345BNubl5L83YWmLbebUcAPKaza5gi17lUW+h/FitzfKAJZ+xsfSdj27nQLa24xYsyB3Fi5DcFLI2oQt5BYAvViT37sabGOXbDBsrijS4t3++mIbC+pCDiKi0hwZzvy0TPRTle2RMhJ6D66DmpykwqBOxzD73fEsieWX4=","name":"textures","value":"eyJ0aW1lc3RhbXAiOjE0ODA1MjA3NjAxNTksInByb2ZpbGVJZCI6ImExNDlmODFiZjc4NDRmODk4N2M1NTRhZmRkNGRiNTMzIiwicHJvZmlsZU5hbWUiOiJsaWJyYXJ5YWRkaWN0Iiwic2lnbmF0dXJlUmVxdWlyZWQiOnRydWUsInRleHR1cmVzIjp7IlNLSU4iOnsidXJsIjoiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS84ZTQ5NDVkMzZjZjVhNjI1OGZjOGY4ZTM5NmZlZWYzMzY1ZjM2MjgyYjE2MjY0OWI2M2NmZWQzNzNmNzY1OSJ9LCJDQVBFIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvZWZkNjFjM2M0YWM4OGYxYTM0NjhmYmRlZWY0NWNlYzg5ZTVhZmI4N2I5N2ExYTg0NWJmYjNjNjRmZDBiODgzIn19fQ=="}]}
  1. Make sure your hunger bar is not full
  2. Make sure you are holding a food item in your main hand
  3. Hold right click while looking at the villager
  4. Watch the trade menu open AND the food item being consumed in the background.

Current behavior

When you have food in your main hand, a non-full hunger bar and you hold right click while looking at a disguised villager, the trade menu pops up, but the player also automatically consumes the item held in the main hand in the background, without the player's input.

Sometimes (and this is really inconsistent, I can't replicate this 100% of the time), the food animation can also play if you just press right click instead of holding it.

Intended correct behavior

In vanilla, food is ignored. This means that even if you are holding a food item while having a non full hunger bar, nothing happens with the food, and the trade menu is opened like normal.

Server log file

https://pastebin.com/S1G9e6k2

Debug log snippet

N/A, no debug logs are generated.

Proposed fixes

Describe what you think the issue or any potential fixes may be.